Skip to content

Remove workaround for bug triggered by Android environment variable#246

Merged
justice-adams-apple merged 1 commit intoswiftlang:mainfrom
finagolfin:env
May 1, 2026
Merged

Remove workaround for bug triggered by Android environment variable#246
justice-adams-apple merged 1 commit intoswiftlang:mainfrom
finagolfin:env

Conversation

@finagolfin
Copy link
Copy Markdown
Member

We had to unset this common Android env var to work around the compiler bug, but it should be fixed in the compiler now.

@finagolfin finagolfin requested a review from a team as a code owner March 19, 2026 14:38
@finagolfin finagolfin marked this pull request as draft March 19, 2026 14:39
@finagolfin
Copy link
Copy Markdown
Member Author

This should be fixed in trunk and will be in the next 6.3 snapshot or release, so getting this cleanup ready for that.

@finagolfin
Copy link
Copy Markdown
Member Author

@marcprux, mind adding a 6.3 release option for Android in this CI sometime today? I'm about to doze off. 😴

@jakepetroules
Copy link
Copy Markdown
Contributor

@finagolfin Can we get this merged?

@finagolfin
Copy link
Copy Markdown
Member Author

The last 6.3 snapshot didn't have the env var fix you approved in swift-driver, so I am waiting for the next 6.3 nightly snapshot to be tagged before merging this, else this will still break nightly-6.3 for Android.

Since unsetting this env var should have no effect on 6.3 and trunk, I'm leaving this workaround in until all three 6.3 and 6.4 builds have the fix.

@finagolfin finagolfin marked this pull request as ready for review April 22, 2026 11:04
@finagolfin
Copy link
Copy Markdown
Member Author

Alright, now that a new 6.3 snapshot was tagged, ready to get this in.

@finagolfin
Copy link
Copy Markdown
Member Author

Anyone know why all the PR workflows are no longer being run on this pull?

We had to unset this common Android env var to work around the compiler bug, but it's
fixed in the compiler now.
@finagolfin
Copy link
Copy Markdown
Member Author

@justice-adams-apple, this is ready to go.

@finagolfin
Copy link
Copy Markdown
Member Author

@ahoppen, just need someone to review this small cleanup.

@ahoppen
Copy link
Copy Markdown
Member

ahoppen commented Apr 30, 2026

Do we have any GitHub actions running that might use a Swift version that doesn’t contain the fix for this issue yet?

@marcprux
Copy link
Copy Markdown
Contributor

Do we have any GitHub actions running that might use a Swift version that doesn’t contain the fix for this issue yet?

I don't think so. The default Android SDK versions for the workflow:

android_sdk_versions:
type: string
description: "Android Swift SDK version list (JSON)"
default: "[\"nightly-main\", \"nightly-6.3\", \"6.3\"]"

So unless anyone has customized android_sdk_versions to explicitly be 6.3.0 (and a quick search against the public repositories doesn't indicate that anyone has), everyone should be running against 6.3.1 or later, and thereby have the fix (swiftlang/swift-driver#1879 and swiftlang/swift-driver#2107) in place.

If any repositories are explicitly using 6.3.0, the canary will be:

<unknown>:0: error: missing required module 'SwiftAndroid'

@finagolfin
Copy link
Copy Markdown
Member Author

6.3.0 has the fix too: the issue was the last 6.3 snapshot before the release, which is no longer a problem with the newer 6.3 snapshots.

@ahoppen, we don't support anything before 6.3 for Android, so this is fixed in all current branches now.

@finagolfin
Copy link
Copy Markdown
Member Author

@marcprux, see the commit that fixed this, swiftlang/swift-driver@7d6b844, the github tag list shows that it made it into both the 6.3 and 6.3.1 releases.

@marcprux
Copy link
Copy Markdown
Contributor

Oh right, I guess I forgot that it got in before 6.3.0. So yes, this should work everywhere.

Copy link
Copy Markdown
Contributor

@justice-adams-apple justice-adams-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@finagolfin
Copy link
Copy Markdown
Member Author

@ahoppen, mind merging? Only reviewers have merge rights on this repo.

@justice-adams-apple justice-adams-apple merged commit a2de0e0 into swiftlang:main May 1, 2026
7 checks passed
@finagolfin finagolfin deleted the env branch May 1, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants